Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "What about PIL?" section #7861

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Update "What about PIL?" section #7861

merged 9 commits into from
Mar 7, 2024

Conversation

aclark4life
Copy link
Member

PyPI moderators gave PIL project to Pillow team in January 2020

Related to #1535 .

Changes proposed in this pull request:

  • Strike through previous statement about PIL
  • Add detail about transfer of project

PyPI moderators gave PIL project to Pillow team in January 2020
@aclark4life
Copy link
Member Author

Screenshot 2024-03-07 at 10 56 40 AM

@hugovk
Copy link
Member

hugovk commented Mar 7, 2024

It seems text-decoration: line-through isn't great for accessibility, some screen readers will still read it out.

Scenario 3 at https://www.webaxe.org/strikethrough-html-accessibility/ is one workaround -- also add a visually-hidden class with some extra explanatory text, and I think we'd also need some relevant CSS to go along with the class and actually visually hide it.

Or scenario 4, but there's some gotchas mentioned there too.

It might be better to rewrite/revise the text instead?

docs/about.rst Outdated Show resolved Hide resolved
@aclark4life
Copy link
Member Author

I'll redo with the suggestions from https://www.webaxe.org/strikethrough-html-accessibility/, thanks!

@hugovk
Copy link
Member

hugovk commented Mar 7, 2024

I'd prefer rewriting so instead the text is up-to-date, rather than asking our users to read then mentally discard the outdated info.

The "As time passes..." sentence is also no longer relevant.

Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
@aclark4life
Copy link
Member Author

aclark4life commented Mar 7, 2024

OK rewrite it is. I merged @nulano 's commit and feel free to further rewrite as needed, thanks all (as well as remove my CSS). rewrote the text! Thanks all

Screenshot 2024-03-07 at 12 06 50 PM

@aclark4life aclark4life requested a review from nulano March 7, 2024 17:08
@aclark4life aclark4life self-assigned this Mar 7, 2024
@aclark4life aclark4life added this to the 10.3.0 milestone Mar 7, 2024
docs/conf.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nulano nulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Yay295
Copy link
Contributor

Yay295 commented Mar 7, 2024

Maybe also add a note to the end that the PIL project on PyPi will be left as it is, and will not be updated to have the Pillow code?

@aclark4life
Copy link
Member Author

@Yay295 I tried to touch on that with "No future releases are planned" with a link to #1535 but let me see …

@hugovk
Copy link
Member

hugovk commented Mar 7, 2024

And update this from "Why a fork?"

-Also, PIL's current bi-yearly (or greater) release schedule is too infrequent to accommodate the large number and frequency of issues reported.
+Also, PIL's bi-yearly (or greater) release schedule was too infrequent to accommodate the large number and frequency of issues reported.

@aclark4life
Copy link
Member Author

Maybe also add a note to the end that the PIL project on PyPi will be left as it is, and will not be updated to have the Pillow code?

966d53b

@aclark4life aclark4life merged commit 658d159 into main Mar 7, 2024
11 checks passed
@aclark4life aclark4life deleted the pil-given-to-pillow branch March 7, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants